Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git requirement from ~> 1.7 to >= 1.7, < 3.0 #280

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 13, 2024

Updates the requirements on git to permit the latest version.

Release notes

Sourced from git's releases.

Release v2.0.0

v2.0.0 (2024-05-10)

Full Changelog

Changes since v2.0.0.pre4:

  • 1afc4c6 Update 2.x release line description
  • ed52420 Make the pull request template more concise
  • 299ae6b Remove stale bot integration
  • efb724b Remove the DCO requirement for commits
Changelog

Sourced from git's changelog.

v2.0.0 (2024-05-10)

Full Changelog

Changes since v2.0.0.pre4:

  • 1afc4c6 Update 2.x release line description
  • ed52420 Make the pull request template more concise
  • 299ae6b Remove stale bot integration
  • efb724b Remove the DCO requirement for commits

v2.0.0.pre4 (2024-05-10)

Full Changelog

Changes since v2.0.0.pre3:

  • 56783e7 Update create_github_release dependency so pre-releases can be made
  • 8566929 Add dependency on create_github_release gem used for releasing the git gem
  • 7376d76 Refactor errors that are raised by this gem
  • 7e99b17 Update documentation for new timeout functionality
  • 705e983 Move experimental builds to a separate workflow that only runs when pushed to master
  • e056d64 Build with jruby-head on Windows until jruby/jruby#7515 is fixed
  • ec7c257 Remove unneeded scripts to create a new release
  • d9570ab Move issue and pull request templates to the .github directory
  • e4d6a77 Show log(x).since combination in README

v2.0.0.pre3 (2024-03-15)

Full Changelog

Changes since v2.0.0.pre2:

  • 5d4b34e Allow allow_unrelated_histories option for Base#pull

v2.0.0.pre2 (2024-02-24)

Full Changelog

Changes since v2.0.0.pre1:

  • 023017b Add a timeout for git commands (#692)
  • 8286ceb Refactor the Error heriarchy (#693)

v2.0.0.pre1 (2024-01-15)

Full Changelog

Changes since v1.19.1:

... (truncated)

Commits
  • 28224a1 Release v2.0.0
  • 1afc4c6 Update 2.x release line description
  • ed52420 Make the pull request template more concise
  • 299ae6b Remove stale bot integration
  • efb724b Remove the DCO requirement for commits
  • d6543aa Release v2.0.0.pre4
  • 56783e7 Update create_github_release dependency so pre-releases can be made
  • 8566929 Add dependency on create_github_release gem used for releasing the git gem
  • 7376d76 Refactor errors that are raised by this gem
  • 7e99b17 Update documentation for new timeout functionality
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels May 13, 2024
@dependabot dependabot bot force-pushed the dependabot/bundler/git-gte-1.7-and-lt-3.0 branch from e7b4fbe to 68ed09c Compare May 17, 2024 11:36
@bastelfreak
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/git-gte-1.7-and-lt-3.0 branch from 68ed09c to ec938c4 Compare May 17, 2024 12:03
@dependabot dependabot bot force-pushed the dependabot/bundler/git-gte-1.7-and-lt-3.0 branch from ec938c4 to 1e769d8 Compare May 17, 2024 16:14
@bastelfreak
Copy link
Member

@dependabot rebase

@bastelfreak bastelfreak force-pushed the dependabot/bundler/git-gte-1.7-and-lt-3.0 branch 2 times, most recently from e5ea486 to e464e6d Compare June 28, 2024 14:57
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.67%. Comparing base (2d8a214) to head (e5ea486).
Report is 4 commits behind head on master.

Current head e5ea486 differs from pull request most recent head bb1d1f0

Please upload reports for the commit bb1d1f0 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #280       +/-   ##
===========================================
+ Coverage   51.62%   86.67%   +35.05%     
===========================================
  Files          28       28               
  Lines        1108     1021       -87     
===========================================
+ Hits          572      885      +313     
+ Misses        536      136      -400     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -47,6 +47,11 @@ jobs:
run: bundle exec rake spec
- name: Run behavior tests
run: bundle exec cucumber
env:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastelfreak bastelfreak force-pushed the dependabot/bundler/git-gte-1.7-and-lt-3.0 branch 2 times, most recently from 214e11f to bb1d1f0 Compare June 28, 2024 15:04
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 1, 2024

A newer version of git exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@ekohl
Copy link
Member

ekohl commented Aug 5, 2024

This one looks related

DEPRECATION WARNING: Git::GitExecuteError is deprecated! Use Git::Error instead. (called from rescue in submit_changes at /home/runner/work/modulesync/modulesync/lib/modulesync/repository.rb:161)

bastelfreak and others added 2 commits August 5, 2024 14:30
Updates the requirements on [git](https://github.com/ruby-git/ruby-git) to permit the latest version.
- [Release notes](https://github.com/ruby-git/ruby-git/releases)
- [Changelog](https://github.com/ruby-git/ruby-git/blob/master/CHANGELOG.md)
- [Commits](ruby-git/ruby-git@v1.7.0...v2.0.0)

---
updated-dependencies:
- dependency-name: git
  dependency-type: direct:production
...
@ekohl ekohl force-pushed the dependabot/bundler/git-gte-1.7-and-lt-3.0 branch from bb1d1f0 to b6060ff Compare August 5, 2024 12:30
@ekohl ekohl removed the tests-fail label Aug 5, 2024
@@ -158,7 +158,7 @@ def submit_changes(files, options)
repo.push('origin', branch, opts_push)
puts "Changes have been pushed to: '#{branch}'"
end
rescue Git::GitExecuteError => e
rescue Git::Error => e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I could solve this deprecation warning:

DEPRECATION WARNING: Git::GitExecuteError is deprecated! Use Git::Error instead. (called from rescue in submit_changes at /home/runner/work/modulesync/modulesync/lib/modulesync/repository.rb:161)

But now: uninitialized constant Git::Error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants